Skip to content

RHDHPAI-1087: Few changes to MCP client configuration #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2025
Merged

RHDHPAI-1087: Few changes to MCP client configuration #1532

merged 2 commits into from
Nov 10, 2025

Conversation

@pabel-rh
Copy link
Member

@pabel-rh pabel-rh commented Nov 7, 2025 •
edited
Loading

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 7, 2025 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1532/ @ 11/08/25 05:36:41

Jdubrick
Jdubrick reviewed Nov 7, 2025
View reviewed changes
Copy link

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benwilcock
Copy link

benwilcock commented Nov 7, 2025

I thought we were going to change the wording used on part 3. "Configure Developer Lightspeed Plugin and Lightspeed Core (LCS) as a client" to "Configuring Developer Lightspeed as a Client" ?

@pabel-rh pabel-rh force-pushed the rhdhpai-1087-mcp-final-updates branch from 72fe72a to 0050a0a Compare November 8, 2025 05:33
@benwilcock
Copy link

benwilcock commented Nov 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 10, 2025
@pabel-rh pabel-rh added Technical review done ⛅ Any procedure has been succesfully tested and removed do-no-merge/review-in-progress 👀 labels Nov 10, 2025
jmagak
jmagak approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@jmagak jmagak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmagak
Copy link
Member

jmagak commented Nov 10, 2025

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 10, 2025

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit d4c7bbb into redhat-developer:main Nov 10, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 10, 2025

@jmagak: new pull request created: #1538

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagak jmagak jmagak approved these changes

+2 more reviewers

@Jdubrick Jdubrick Jdubrick left review comments

@maysunfaisal maysunfaisal maysunfaisal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benwilcock benwilcock

Labels

lgtm Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pabel-rh @rhdh-bot @benwilcock @jmagak @openshift-cherrypick-robot @maysunfaisal @Jdubrick